---
title: PR Best Practices
impact: HIGH
impactDescription: Ensures smooth code review and merge process
tags: quality, pr, git, review
---
## Паспорт документа

- Статус документа: living standard
- Актуально на: 28 марта 2026 года
- Владелец: backend/platform-команда
- Пересмотр: при изменении инженерной практики, CI/CD, архитектурных правил или локального workflow
- Область применения: внутренние rule/reference-card документы для инженерной команды
- Связанные документы:
  - [Индекс Agents](../README.md)
  - [Команды разработки](../commands.md)
  - [Инженерные принципы](../../governance/engineering-principles.md)

## PR Best Practices

**Impact: HIGH**

### PR Title Convention

Follow conventional commits:
```
feat(catalog): add subject filter to course search
fix(auth): handle expired refresh token gracefully
refactor(seller): extract item validation to shared schema
chore(deps): update Prisma to 6.x
```

### PR Size

- Keep under 500 lines of code changes
- Keep under 10 files changed
- One PR = one logical change

### PR Checklist

Before opening a PR:
1. Run `pnpm type-check` — all types must pass
2. Run `pnpm lint` — no lint errors
3. Run relevant tests
4. Verify Prisma queries use `select` (not `include`)
5. Verify no `"use client"` without justification
6. Verify no secrets or `.env` values in code
7. Verify UI strings are in translation files

### Draft PRs

Always create PRs in draft mode. Mark as ready for review only when:
- All CI checks pass
- Self-review is complete
- Description explains the "why" not just the "what"